Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-1553: Added multi vCenter support for capi installer. #8221

Merged
merged 1 commit into from
Jun 15, 2024
Merged

SPLAT-1553: Added multi vCenter support for capi installer. #8221

merged 1 commit into from
Jun 15, 2024

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Apr 1, 2024

SPLAT-1553

Changes

  • Added logic to create VM components on multiple vCenters

Dependencies

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 1, 2024 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-1553 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

SPLAT-1553

Changes

  • Added logic to create VM components on multiple vCenters

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024
@vr4manta vr4manta mentioned this pull request May 6, 2024
Merged
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@vr4manta vr4manta force-pushed the SPLAT-1553 branch 3 times, most recently from d323f77 to 83d2537 Compare May 8, 2024 14:04
@vr4manta vr4manta mentioned this pull request May 9, 2024
Draft
@vr4manta
Copy link
Contributor Author

vr4manta commented May 9, 2024

/payload-job-with-prs periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn #8221 openshift/vmware-vsphere-csi-driver#117 openshift/vmware-vsphere-csi-driver-operator#228 openshift/cluster-storage-operator#465 openshift/machine-config-operator#4298

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

@vr4manta: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@vr4manta
Copy link
Contributor Author

vr4manta commented May 9, 2024

/payload-job-with-prs periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn openshift/vmware-vsphere-csi-driver#117 openshift/vmware-vsphere-csi-driver-operator#228 openshift/cluster-storage-operator#465 openshift/machine-config-operator#4298

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

@vr4manta: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@vr4manta
Copy link
Contributor Author

vr4manta commented May 9, 2024

/payload-job-with-prs periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn openshift/vmware-vsphere-csi-driver#117 openshift/vmware-vsphere-csi-driver-operator#228 openshift/cluster-storage-operator#465 openshift/machine-config-operator#4298

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2b3196f0-0dfa-11ef-91c8-1b3bdde4af13-0

This was referenced May 9, 2024
Merged
Draft
Open
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 972c722 and 2 for PR HEAD 78d0ebb in total

@vr4manta
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD cb6ced8 and 1 for PR HEAD 78d0ebb in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f4d64f0 and 0 for PR HEAD 78d0ebb in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 78d0ebb was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2024
@vr4manta
Copy link
Contributor Author

/retest-required

@vr4manta
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a81e877 and 2 for PR HEAD 78d0ebb in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c747c05 and 1 for PR HEAD 78d0ebb in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4524922 and 0 for PR HEAD 78d0ebb in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 15, 2024 •
edited
Loading

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-e2e-vsphere-capi-multi-vcenter-ovn 8be1d73 link false /test altinfra-e2e-vsphere-capi-multi-vcenter-ovn
ci/prow/okd-e2e-aws-ovn-upgrade 80a1da3 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-images 8be1d73 link true /test okd-images
ci/prow/e2e-vsphere-zones-techpreview 80a1da3 link false /test e2e-vsphere-zones-techpreview
ci/prow/e2e-vsphere-ovn-upi 80a1da3 link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-vsphere-ovn-zones-techpreview 78d0ebb link false /test e2e-vsphere-ovn-zones-techpreview
ci/prow/e2e-openstack-nfv-intel 78d0ebb link false /test e2e-openstack-nfv-intel
ci/prow/e2e-aws-ovn-fips 78d0ebb link false /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-edge-zones 78d0ebb link false /test e2e-aws-ovn-edge-zones
ci/prow/altinfra-e2e-aws-ovn 78d0ebb link false /test altinfra-e2e-aws-ovn
ci/prow/e2e-azurestack 78d0ebb link false /test e2e-azurestack
ci/prow/e2e-openstack-proxy 78d0ebb link false /test e2e-openstack-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 78d0ebb was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2024
@patrickdillon
Copy link
Contributor

/skip

@patrickdillon
Copy link
Contributor

/override ci/prow/e2e-openstack-ovn
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 15, 2024

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-openstack-ovn

In response to this:

/override ci/prow/e2e-openstack-ovn
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ee1c8c0 into openshift:master Jun 15, 2024
43 checks passed
neisw added a commit to neisw/installer that referenced this pull request Jun 18, 2024
@neisw
Revert "Merge pull request openshift#8221 from vr4manta/SPLAT-1553"
a3461e7 
This reverts commit ee1c8c0, reversing
changes made to 4524922.
@neisw neisw mentioned this pull request Jun 18, 2024
Merged
openshift-merge-bot bot added a commit that referenced this pull request Jun 19, 2024
@openshift-merge-bot
Merge pull request #8630 from neisw/revert-8221-1718750149043
251f3a2 
Revert #8221 "SPLAT-1553: Added multi vCenter support for capi installer."
vr4manta added a commit to vr4manta/installer that referenced this pull request Jun 20, 2024
@vr4manta
Revert "Revert openshift#8221 "SPLAT-1553: Added multi vCenter suppor…
4816d51 
…t for capi installer.""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 left review comments

@rwsu rwsu rwsu left review comments

@patrickdillon patrickdillon patrickdillon left review comments

@jcpowermac jcpowermac jcpowermac left review comments

Assignees

@patrickdillon patrickdillon

@jcpowermac jcpowermac

@rvanderp3 rvanderp3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@vr4manta @openshift-ci-robot @jcpowermac @rvanderp3 @r4f4 @patrickdillon @rwsu @openshift-merge-robot